Skip to content
This repository has been archived by the owner on Sep 28, 2021. It is now read-only.

Upgrade semantic metrics to 1.1.7 #330

Merged
merged 1 commit into from
Feb 19, 2021
Merged

Upgrade semantic metrics to 1.1.7 #330

merged 1 commit into from
Feb 19, 2021

Conversation

lmuhlha
Copy link
Member

@lmuhlha lmuhlha commented Feb 11, 2021

Latest release: https://github.com/spotify/semantic-metrics/releases/tag/1.1.7

Note: This is a breaking change if you were querying for sprawling keys (ex: apollo.apollo.apollo.apollo). You may have to update your queries to use the non-sprawling key. If you are not using a key in your query, the results should stay the same.

Would be good to add that note to the release notes for apollo as well :)

@codecov
Copy link

codecov bot commented Feb 11, 2021

Codecov Report

Merging #330 (03e786d) into 1.x (7a49695) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##                1.x     #330   +/-   ##
=========================================
  Coverage     71.85%   71.85%           
  Complexity      668      668           
=========================================
  Files           136      136           
  Lines          2857     2857           
  Branches        168      168           
=========================================
  Hits           2053     2053           
  Misses          766      766           
  Partials         38       38           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7a49695...03e786d. Read the comment docs.

@lmuhlha lmuhlha marked this pull request as ready for review February 11, 2021 21:21
@klaraward
Copy link
Contributor

@lmuhlha Is the usage of sprawling keys common, how would you find it in codebase?

@lmuhlha
Copy link
Member Author

lmuhlha commented Feb 16, 2021

Screen Shot 2021-02-16 at 10 40 23 AM
Checking with bigquery on the heroic query dataset, there are about 1039 queries with apollo.apollo as they key in a day. Anything more than that (like apollo.apollo.apollo, apollo.apollo.apollo.apollo, etc) doesn't seem to be queried on average. Since there is a prefix in a key, apollo.apollo may just be an accurate key where apollo has the prefix set to apollo followed by a normal apollo key. So some, if not all, might not be changed in the case of the 1039 queries. It's just something people should be aware of when upgrading as a precaution.

@lmuhlha
Copy link
Member Author

lmuhlha commented Feb 16, 2021

In reference to Grafana, it's this:
Screen Shot 2021-02-16 at 10 45 17 AM

@klaraward klaraward merged commit 195384a into 1.x Feb 19, 2021
@lmuhlha lmuhlha deleted the semmetrics1.1.7 branch February 19, 2021 19:22
klaraward added a commit that referenced this pull request Apr 22, 2021
Reverts #330, which causes problems in downstream dependencies because of the removal of all shaded libraries in ffwd-http-client
Will update to new version of semantic-metrics once #342 has been merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants