This repository has been archived by the owner on Sep 28, 2021. It is now read-only.
Don't support ffwd over http anymore, use semantic-metrics 1.1.8 where the lib is not included. #342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lmuhlha
approved these changes
Apr 21, 2021
|
We still have a problem with using a new version of semantic-metrics, because it brings in the new ffwd-http-client without the shaded dependencies, that too many people depend on. |
klaraward
changed the title
lepistone
approved these changes
Apr 28, 2021
There was a problem hiding this comment.
Sounds great together with spotify/semantic-metrics#108. Thank you!
klaraward
force-pushed
the
no-ffwd-http-client
branch
from
e5c64a4
to
718bbde
Compare
Codecov Report
@@ Coverage Diff @@
## 1.x #342 +/- ##
============================================
+ Coverage 71.96% 72.04% +0.07%
+ Complexity 676 673 -3
============================================
Files 138 137 -1
Lines 2904 2862 -42
Branches 169 167 -2
============================================
- Hits 2090 2062 -28
+ Misses 776 763 -13
+ Partials 38 37 -1
Continue to review full report at Codecov.
|
toweroy
reviewed
May 6, 2021
toweroy
reviewed
May 6, 2021
| @@ -162,19 +162,20 @@ | |||
| </dependency> | |||
| <dependency> | |||
| <groupId>com.spotify.metrics</groupId> | |||
| <artifactId>semantic-metrics-core</artifactId> | |||
| <artifactId>semantic-metrics-bom</artifactId> | |||
| <version>${semantic-metrics.version}</version> | |||
There was a problem hiding this comment.
If we will use the semantic-metrics-bom now, is this parameter required?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Can not find any usages of the config
ffwd.type: httpin the Spotify code base, and I believe @lmuhlha said she wants to get rid of the ffwd-http-client library - #326 (comment)Include the old version of
ffwd-http-clientlib to make sure downstream libraries get that as a transitive dependency and can use the shaded packages.