upgrade all dev deps. use web-scripts for eslint

.eslintrc.js

@@ -1,21 +1 @@
-module.exports = {
-
-  extends: 'eslint-config-airbnb',
-
-  parserOptions: {
-    // This is to avoid eslint complaining:
-    //    'use strict' is unnecessary inside of modules
-    // we need 'use strict' on node4 because only in strict mode do
-    // block-scoped let/const operate.
-    sourceType: 'script',
-  },
-
-  rules: {
-    // Again, override airbnb so that it allows a use strict in node4
-    strict: ['error', 'safe'],
-
-    // Allow 'use strict' to have the shebang line for bin/cli.js
-    'lines-around-directive': ['error', 'always']
-  }
-
-}
+module.exports = require('@spotify/web-scripts/config/eslintrc.js');

bin/cli.js

@@ -19,16 +19,16 @@
 const fs = require('fs');
 const path = require('path');
 
+// https://github.com/nodejs/node/issues/6456
+// Prevent truncated output on unhandledExeception(s).
+const setBlocking = require('set-blocking');
+
 const minimist = require('minimist');
 const debug = require('debug');
 const pkg = require('../package.json');
 
 const dbg = debug(`${pkg.name}:cli`);
 
-// https://github.com/nodejs/node/issues/6456
-// Prevent truncated output on unhandledExeception(s).
-const setBlocking = require('set-blocking');
-
 setBlocking(true);
 
 const defaults = require('../lib/default-options');

lib/discern-files.js

@@ -22,7 +22,6 @@ const isLikelyGlob = require('./is-likely-glob');
 
 const dbg = debug(`${pkg.name}:discern-files`);
 
-
 module.exports = function discernFiles(fs, args, resolveFiles) {
   const files = [];
 

lib/run.js

@@ -12,50 +12,57 @@
 // License for the specific language governing permissions and limitations under
 // the License.
 
-'use strict';
+"use strict";
 
-const exec = require('child_process').exec;
-const path = require('path');
-const objectAssign = require('object-assign');
-const debug = require('debug');
-const pkg = require('../package.json');
+const { exec } = require("child_process");
+const path = require("path");
+const objectAssign = require("object-assign");
+const debug = require("debug");
+const pkg = require("../package.json");
 
 const dbg = debug(`${pkg.name}:run`);
 
 module.exports = function runExec(cmd, opts, cb) {
-  const binPath = path.join(process.cwd(), 'node_modules/.bin/');
+  const binPath = path.join(process.cwd(), "node_modules/.bin/");
 
-  const env = objectAssign(
-    {},
-    process.env,
-    { PATH: `${binPath}:${process.env.PATH}` }
-  );
+  const env = objectAssign({}, process.env, {
+    PATH: `${binPath}:${process.env.PATH}`,
+  });
 
-  dbg('exec %s', cmd);
+  dbg("exec %s", cmd);
 
   // We buffer stdout/stderr manually to both prevent configuring maxBuffer
   // and to have unified event handling on the process.
-  let stdout = '';
-  let stderr = '';
+  let stdout = "";
+  let stderr = "";
 
   const child = exec(cmd, {
     env,
-    encoding: 'utf-8',
+    encoding: "utf-8",
   });
 
-  if (opts['stream-output']) {
+  if (opts["stream-output"]) {
     child.stdout.pipe(process.stdout);
     child.stderr.pipe(process.stderr);
   } else {
-    child.stdout.on('data', (chunk) => { stdout += chunk; });
-    child.stderr.on('data', (chunk) => { stderr += chunk; });
+    child.stdout.on("data", (chunk) => {
+      stdout += chunk;
+    });
+    child.stderr.on("data", (chunk) => {
+      stderr += chunk;
+    });
   }
 
   // `close` is used because `exit` can fire before the final `data` event
   // is emitted from stdout/stderr streams, in the case of buffering.
-  child.on('close', (code, signal) => {
-    dbg('exec close, code %s, signal %s, stdout.length %d, stderr.length %d',
-      code, signal, stdout.length, stderr.length);
+  child.on("close", (code, signal) => {
+    dbg(
+      "exec close, code %s, signal %s, stdout.length %d, stderr.length %d",
+      code,
+      signal,
+      stdout.length,
+      stderr.length
+    );
 
     // These will be empty strings if stream-output === true
     // Note: previous versions used console.log for both of these streams.
@@ -72,5 +79,5 @@ module.exports = function runExec(cmd, opts, cb) {
   // This is not if the child process exits in error, but more if the process
   // cannot be spawned for some reason. In this situation, the `close` event
   // shouldn't fire because a process was never spawned.
-  child.on('error', cb);
+  child.on("error", cb);
 };

package.json

@@ -42,17 +42,13 @@
   "author": "Drew Petersen <drewp@spotify.com>",
   "license": "Apache-2.0",
   "devDependencies": {
-    "coveralls": "^2.11.9",
-    "eslint": "^3.8.1",
-    "eslint-config-airbnb": "^12.0.0",
-    "eslint-plugin-import": "^1.16.0",
-    "eslint-plugin-jsx-a11y": "^2.2.3",
-    "eslint-plugin-react": "^6.4.1",
+    "@spotify/web-scripts": "^8.1.1",
+    "coveralls": "^3.1.0",
     "in-publish": "^2.0.0",
     "istanbul": "^1.0.0-alpha.2",
-    "mocha": "^2.4.5",
-    "nyc": "^6.4.0",
-    "tape": "^4.5.1"
+    "mocha": "^8.2.0",
+    "nyc": "^15.1.0",
+    "tape": "^5.0.1"
   },
   "dependencies": {
     "async": "^3.2.0",

prettier.config.js

@@ -0,0 +1 @@
+module.exports = require('@spotify/web-scripts/config/prettier.config.js');

tests/unit/generate-commands.js

@@ -14,6 +14,9 @@
 
 'use strict';
 
+/* eslint-disable jest/expect-expect */
+/* eslint-disable jest/no-test-callback */
+
 const test = require('tape');
 
 const generateCommands = require('../../lib/generate-commands');

tests/unit/partition-by-pattern.js

@@ -14,6 +14,9 @@
 
 'use strict';
 
+/* eslint-disable jest/expect-expect */
+/* eslint-disable jest/no-test-callback */
+
 const test = require('tape');
 
 const partitionByPattern = require('../../lib/partition-by-pattern');

tests/unit/partition-by-size.js

@@ -14,6 +14,9 @@
 
 'use strict';
 
+/* eslint-disable jest/expect-expect */
+/* eslint-disable jest/no-test-callback */
+
 const test = require('tape');
 
 const partitionBySize = require('../../lib/partition-by-size');

tests/unit/run.js

@@ -14,6 +14,9 @@
 
 'use strict';
 
+/* eslint-disable jest/expect-expect */
+/* eslint-disable jest/no-test-callback */
+
 const test = require('tape');
 const run = require('../../lib/run');