fix: widen flag return types #142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andreas-karlsson
requested review from
Billlynch,
fabriziodemaria,
mfranberg,
vahidlazio,
nicklasl and
nickybondarenko
as code owners
nicklasl
previously approved these changes
May 22, 2024
nicklasl
approved these changes
May 24, 2024
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi There, I just made a Pull Request!
Right now we have an issue that flag value types are too aggressively "narrowed" by TS. For instance:
Right now TS will infer the type of value to be
3withe the desired type beingnumber. This PR fixes that. Ideally we should have type tests for this sort of thing. But that is saved for another day.✔️ Checklist