Concurrent networking #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Calibretto
force-pushed
the
networking
branch
2 times, most recently
from
e8b8121
to
0ee6bcf
Compare
Calibretto
commented
Jul 20, 2023
fabriziodemaria
approved these changes
Jul 27, 2023
Sources/ConfidenceProvider/ConfidenceClient/ConfidenceClient.swift
Outdated
Show resolved
Hide resolved
…tor provider to rely on local cache.
fabriziodemaria
approved these changes
Aug 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR splits the closure style request and the async request into two separate paths - this seems to be the most reliable way to handle it. A synchronous version has been removed as there's no reliable way to achieve it, due to threading issues (we can spend some more time investigating when it comes time to implement the dynamic context).
I'm not 100% comfortable with the way the resolver and the cache are interacting - I think it's maybe just the naming of things that's confusing me - if we have time before the beta release I'd like to go back and take a look at it.