feat: Add resolving against confidence context #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vahidlazio
force-pushed
the
of-resolve-conf-context
branch
4 times, most recently
from
65da6ea
to
c062d59
Compare
vahidlazio
requested review from
fabriziodemaria,
mfranberg,
nicklasl and
nickybondarenko
as code owners
Co-authored-by: Fabrizio Demaria <fabrizio.f.demaria@gmail.com>
vahidlazio
force-pushed
the
of-resolve-conf-context
branch
from
1e4b9bb
to
dcc53b9
Compare
| @@ -399,7 +409,6 @@ public class ConfidenceFeatureProvider: FeatureProvider { | |||
|
|
|||
| private func processResultForApply( | |||
| resolverResult: ResolveResult?, | |||
| ctx: OpenFeature.EvaluationContext?, | |||
fabriziodemaria
previously approved these changes
Apr 24, 2024
There was a problem hiding this comment.
Only this minor comment if you think it's worth acting on it: #94 (comment)
fabriziodemaria
approved these changes
Apr 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.