Add java-11-amazon-corretto-jdk package dep #203
Conversation
agent/src/deb/control/control
Outdated
| @@ -10,6 +10,6 @@ Build-Depends: | |||
| maven (>= 3) | |||
| Standards-Version: 3.9.1 | |||
| Architecture: all | |||
| Depends: oracle-jvm-11 (>=11.0.2-1spotify1) | openjdk-11-jre-headless | |||
| Depends: java-11-amazon-corretto-jdk (>=1:11.0.7.10-1) | oracle-jvm-11 (>=11.0.2-1spotify1) | openjdk-11-jre-headless | |||
There was a problem hiding this comment.
if we add this dependency will it be installed during the build?
agent/src/deb/control/control
Outdated
| @@ -10,6 +10,6 @@ Build-Depends: | |||
| maven (>= 3) | |||
| Standards-Version: 3.9.1 | |||
| Architecture: all | |||
| Depends: oracle-jvm-11 (>=11.0.2-1spotify1) | openjdk-11-jre-headless | |||
| Depends: java-11-amazon-corretto-jdk (>=1:11.0.7.10-1) | oracle-jvm-11 (>=11.0.2-1spotify1) | openjdk-11-jre-headless | |||
There was a problem hiding this comment.
The | operator for Depends is an or operator right? So this indicates that java-11-amazon-corretto-jdk should be installed to fulfill the dependency group (strung together by |s) but if it's unavailable, either of the other two can be installed?
|
Noting also that this PR/change will allow VMs/runtimes that are using the version of |
|
@RochesterinNYC we can wait until corretto/corretto-11#113 is addressed to move forward with this. |
smstone
force-pushed
the
add-corretto-debian-control
branch
from
6186396
to
2c1d009
Compare
|
@malish8632 @lmuhlha @RochesterinNYC We have the noalt package available to us now. Can you PTAL? |
@lmuhlha @malish8632 @sjoeboo @RochesterinNYC
#200 only added support for running with Corretto if it was available. These changes allow to have Corretto, Oracle, or OpenJDK satisfy the Depends field.