Fix flake errors after moving to python 3 #2695
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sync with the main repo
- changed `track_url_in_stderr` to `stream_for_searching_tracking_url` according to the latest changes in external_program.py - added tests for spark url tracking in cluster and client modes
In-sync with master
Merge into the fork
GoodDok
force-pushed
the
fix-flake-errors-after-moving-to-python-3
branch
3 times, most recently
from
64fe0cf
to
bad8e2c
Compare
GoodDok
force-pushed
the
fix-flake-errors-after-moving-to-python-3
branch
from
bad8e2c
to
91bf5f2
Compare
|
Thanks for looking after our build status! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixed flake errors on Python 3.
Regarding
builtins = unicode: see https://www.dangtrinh.com/2018/02/how-to-fix-f821-undefined-name-unicode.htmlMotivation and Context
From https://travis-ci.org/spotify/luigi/jobs/520087734:
Starting from 2019-04-16 builds started to fail (for example, https://travis-ci.org/spotify/luigi/jobs/520844168) showing the errors that haven't been recognized before and preventing other PRs to be built successfully.
Have you tested this? If so, how?
Automatic Travis tests + locally