Force avro String type in generated schema #730
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| implicit val afString: AvroField[String] = new Aux[String, String, String] { | ||
| override protected def buildSchema(cm: CaseMapper): Schema = { | ||
| val schema = Schema.create(Schema.Type.STRING) | ||
| GenericData.setStringType(schema, GenericData.StringType.String) |
There was a problem hiding this comment.
TIL about this method! nice
RustedBones
force-pushed
the
avro-char-seq-string
branch
from
ff011d0
to
982ed24
Compare
RustedBones
commented
Apr 25, 2023
Comment on lines
-200
to
-201
| implicit val afUnit = | ||
| aux2[Unit, JsonProperties.Null](Schema.Type.NULL)(_ => ())(_ => JsonProperties.NULL_VALUE) |
There was a problem hiding this comment.
I don't know why we had this. The generated data looked incorrect and having a data model containing a Unit field looks wrong to me. I replaced with a afNull in case we want to get a schema with null type.
Codecov Report
@@ Coverage Diff @@
## main #730 +/- ##
==========================================
- Coverage 94.99% 94.97% -0.03%
==========================================
Files 52 52
Lines 1779 1790 +11
Branches 169 171 +2
==========================================
+ Hits 1690 1700 +10
- Misses 89 90 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
clairemcginty
approved these changes
Apr 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
scala/java
Stringwill be represented in with the"avro.java.string": "String"property in the avro schema.Logical types baked by avro string should be created using the
CharSequencetype as the property is forbidden there (exception is thrown when building the schema)