Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support accessing all counters within JobTest #2007

Closed
catherinejelder opened this issue Jun 28, 2019 · 2 comments
Closed

support accessing all counters within JobTest #2007

catherinejelder opened this issue Jun 28, 2019 · 2 comments
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@catherinejelder
Copy link

I would like to be able to access counters within in a JobTest without knowing their names in advance, maybe with a .counters method that returns all counters.

@nevillelyh nevillelyh added enhancement New feature or request good first issue Good for newcomers labels Jun 28, 2019
@nevillelyh
Copy link
Contributor

Should be easy to impl. It's a matter of adding methods similar to counter/distribution/gauge here that take an assertion fn and calling it in the metricsFn here.

@rulle-io
Copy link

@catherinejelder Can you, please, provide an example code snippet, showing how do you want to access counters within in a JobTest.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

4 participants