New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stop using forked magnolia #2192
Comments
Given this, nothing really stop us from forking these two libs and publish them for Tbh, I tend to prefer this way as opposed to have two different versions. This is a bit more work, but at least things are bit more consistent. |
So latest magnolia HEAD no longer builds for scala 2.11 because:
Do we want to keep patching both magnolia & mercator and release our forks? Feels like it's easier to use forked one for 2.11 and latest vanilla release for 2.12 & 2.13.
|
https://github.com/spotify/scio/blob/master/build.sbt#L375
Just realized that we're still using a forked magnolia, and can't use latest upstream since they dropped 2.11 support. We should figure out a way forward and minimize custom stuff.
softwaremill/magnolia#171
One solution might be using our fork for 2.11, and latest upstream for 2.12, and drop 2.11 when we move to 2.13.
The text was updated successfully, but these errors were encountered: