Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop using forked magnolia #2192

Closed
nevillelyh opened this issue Aug 27, 2019 · 2 comments
Closed

Stop using forked magnolia #2192

nevillelyh opened this issue Aug 27, 2019 · 2 comments
Labels
bug Something isn't working

Comments

@nevillelyh
Copy link
Contributor

https://github.com/spotify/scio/blob/master/build.sbt#L375

Just realized that we're still using a forked magnolia, and can't use latest upstream since they dropped 2.11 support. We should figure out a way forward and minimize custom stuff.

softwaremill/magnolia#171

One solution might be using our fork for 2.11, and latest upstream for 2.12, and drop 2.11 when we move to 2.13.

@nevillelyh nevillelyh added the bug Something isn't working label Aug 27, 2019
@regadas
Copy link
Contributor

regadas commented Aug 30, 2019

magnolia and it's dependency mercator are no longer published for 2.11 due to some weird scalac issues that pop up mainly (and this is the case i remember) when doing type class derivation for recursive types and when doing kind projection.

Given this, nothing really stop us from forking these two libs and publish them for 2.11 (I tested it briefly and it's doable).

Tbh, I tend to prefer this way as opposed to have two different versions. This is a bit more work, but at least things are bit more consistent.

@nevillelyh
Copy link
Contributor Author

So latest magnolia HEAD no longer builds for scala 2.11 because:

Do we want to keep patching both magnolia & mercator and release our forks? Feels like it's easier to use forked one for 2.11 and latest vanilla release for 2.12 & 2.13.

[error] /home/neville/src/oss/magnolia/core/shared/src/main/scala/magnolia.scala:214:64: value isJavaAnnotation is not a member of c.universe.Symbol
[error]       val isJavaAnnotation: Tree => Boolean = _.tpe.typeSymbol.isJavaAnnotation
[error]                                                                ^
[error] /home/neville/src/oss/magnolia/core/shared/src/main/scala/magnolia.scala:214:64: value isJavaAnnotation is not a member of c.universe.Symbol
[error]       val isJavaAnnotation: Tree => Boolean = _.tpe.typeSymbol.isJavaAnnotation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants