Avro regenerates referenced definitions

[cptaffe]

In Scio 0.7.4, @AvroType.fromSchema regenerates case classes for previously seen definitions instead of reusing them, which breaks types which have multiple members of the same type.

@AvroType.fromSchema(
  """
  |{
  |  "type" : "record",
  |  "name" : "A",
  |  "fields" : [ {
  |    "name" : "a",
  |    "type" : {
  |      "type" : "record",
  |      "name" : "B",
  |      "fields" : [ ]
  |    }
  |  }, {
  |    "name" : "b",
  |    "type" : "B"
  |  } ]
  |}""".stripMargin
)
class ReuseDef

This example fails with:

ReuseDef$B is already defined as case class ReuseDef$B

avro-tool idl2schemata will generate this case from this IDL input:

protocol test {
  record B {}

  record A {
    B a;
    B b;
  }
}

[clairemcginty]

thanks for reporting! We should probably add a check to the Avro TypeProvider that keeps track of previously seen record definitions.