Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use coherent defaults accross IO #1478

Merged
merged 7 commits into from Oct 23, 2018
Merged

Use coherent defaults accross IO #1478

merged 7 commits into from Oct 23, 2018

Conversation

regadas
Copy link
Contributor

@regadas regadas commented Oct 19, 2018

No description provided.

@codecov
Copy link

codecov bot commented Oct 19, 2018

Codecov Report

Merging #1478 into master will decrease coverage by 10.25%.
The diff coverage is 59.25%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #1478       +/-   ##
===========================================
- Coverage   78.92%   68.66%   -10.26%     
===========================================
  Files         170      170               
  Lines        5153     5177       +24     
  Branches      317      339       +22     
===========================================
- Hits         4067     3555      -512     
- Misses       1086     1622      +536
Impacted Files Coverage Δ
.../scala/com/spotify/scio/avro/AvroSCollection.scala 100% <ø> (ø) ⬆️
...om/spotify/scio/bigquery/BigQueryScioContext.scala 60% <ø> (ø) ⬆️
...scala/com/spotify/scio/elasticsearch/package.scala 0% <0%> (ø) ⬆️
...scala/com/spotify/scio/cassandra/CassandraIO.scala 0% <0%> (ø) ⬆️
...m/spotify/scio/elasticsearch/ElasticsearchIO.scala 0% <0%> (ø) ⬆️
...ain/scala/com/spotify/scio/cassandra/package.scala 0% <0%> (ø) ⬆️
...ain/scala/com/spotify/scio/cassandra/package.scala 0% <0%> (ø) ⬆️
...m/spotify/scio/elasticsearch/ElasticsearchIO.scala 0% <0%> (ø) ⬆️
...scala/com/spotify/scio/cassandra/CassandraIO.scala 0% <0%> (ø) ⬆️
...scala/com/spotify/scio/elasticsearch/package.scala 0% <0%> (ø) ⬆️
... and 42 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 073959c...1fc8cca. Read the comment docs.

@regadas regadas removed the WIP label Oct 20, 2018
Copy link
Contributor

@jto jto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@regadas regadas merged commit 93fe14f into spotify:master Oct 23, 2018
@regadas regadas deleted the fix/1471 branch October 23, 2018 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants