Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pubusb topic name was not being set for Message + PubsubMessge #1568

Merged
merged 1 commit into from Dec 4, 2018

Conversation

clairemcginty
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Dec 4, 2018

Codecov Report

Merging #1568 into master will increase coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1568      +/-   ##
==========================================
+ Coverage   69.88%   69.88%   +<.01%     
==========================================
  Files         171      171              
  Lines        5246     5243       -3     
  Branches      397      289     -108     
==========================================
- Hits         3666     3664       -2     
+ Misses       1580     1579       -1
Impacted Files Coverage Δ
.../src/main/scala/com/spotify/scio/io/PubsubIO.scala 12.5% <0%> (ø) ⬆️
.../src/main/scala/com/spotify/scio/avro/AvroIO.scala 93.54% <0%> (-0.21%) ⬇️
.../spotify/scio/tensorflow/TensorFlowFunctions.scala 85.71% <0%> (+0.93%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8bd5fbb...b1ffc2c. Read the comment docs.

@regadas regadas merged commit a48d2ac into master Dec 4, 2018
@clairemcginty clairemcginty deleted the claire/ps_fix branch December 4, 2018 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants