Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add simple toString to coders #1671

Merged
merged 1 commit into from Feb 8, 2019
Merged

Add simple toString to coders #1671

merged 1 commit into from Feb 8, 2019

Conversation

regadas
Copy link
Contributor

@regadas regadas commented Feb 7, 2019 •
edited

Fixes #1667

clairemcginty
clairemcginty approved these changes Feb 8, 2019
View reviewed changes
scio-core/src/main/scala/com/spotify/scio/coders/Coder.scala
.map {
case (k, v) => s"($k, $v)"
}
s"Record($typeName, ${str.mkString(", ")})"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@regadas regadas merged commit b89781e into spotify:master Feb 8, 2019
@regadas regadas deleted the feature/coder-tostring branch February 8, 2019 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clairemcginty clairemcginty clairemcginty approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@regadas @clairemcginty