Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor doc site fix #1759

Merged
merged 2 commits into from Mar 18, 2019
Merged

Minor doc site fix #1759

merged 2 commits into from Mar 18, 2019

Conversation

regadas
Copy link
Contributor

@regadas regadas commented Mar 18, 2019

No description provided.

@regadas regadas mentioned this pull request Mar 18, 2019
@codecov
Copy link

codecov bot commented Mar 18, 2019

Codecov Report

Merging #1759 into master will decrease coverage by 2.5%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1759      +/-   ##
==========================================
- Coverage   71.65%   69.14%   -2.51%     
==========================================
  Files         175      175              
  Lines        5383     5383              
  Branches      408      416       +8     
==========================================
- Hits         3857     3722     -135     
- Misses       1526     1661     +135
Impacted Files Coverage Δ
.../spotify/scio/bigquery/client/BigQueryConfig.scala 0% <0%> (-70.59%) ⬇️
...scala/com/spotify/scio/bigquery/client/Cache.scala 0% <0%> (-66.67%) ⬇️
.../spotify/scio/bigquery/BigQueryPartitionUtil.scala 0% <0%> (-58.98%) ⬇️
...scala/com/spotify/scio/bigquery/BigQueryUtil.scala 50% <0%> (-50%) ⬇️
...la/com/spotify/scio/bigquery/client/QueryOps.scala 0.82% <0%> (-47.11%) ⬇️
...com/spotify/scio/bigquery/types/BigQueryType.scala 37.5% <0%> (-25%) ⬇️
...la/com/spotify/scio/bigquery/client/TableOps.scala 0% <0%> (-22.37%) ⬇️
...la/com/spotify/scio/bigquery/client/BigQuery.scala 27.02% <0%> (-10.82%) ⬇️
...n/scala/com/spotify/scio/bigquery/BigQueryIO.scala 24.29% <0%> (-3.74%) ⬇️
...com/spotify/scio/bigquery/types/TypeProvider.scala 76.59% <0%> (-2.13%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 92264ae...21e1237. Read the comment docs.

@@ -5,4 +5,4 @@
# SOCCO=true sbt scio-examples/clean scio-examples/compile site/makeSite

# generate new site and push to GitHub
SOCCO=true sbt scio-examples/clean scio-examples/compile site/ghpagesPushSite
SOCCO=true sbt scio-examples/clean scio-examples/compile #site/ghpagesPushSite
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

# generate new site and push to GitHub is no longer completely accurate with this commented out?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah that was committed by mistake 😄

@regadas regadas merged commit 8c011d3 into spotify:master Mar 18, 2019
@regadas regadas deleted the fix/scaladocs-links branch March 18, 2019 16:36
nevillelyh pushed a commit that referenced this pull request Mar 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants