Add fluent backoff support for ES #1826
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implements retries when saving bulk documents to Elasticsearch. This is useful for transient connection problems and other failures which are temporary in nature. The current behavior will cause the entire "Save to Elasticsearch" step to fail and retry, which creates redundant saves to the cluster. There is no existing method to enable a single failed chunk to retry. This behavior is implemented with two new options, withMaxRetries and withRetryPause, which can be passed in the configuration as "maxRetries" and "retryPause" respectively. Catch all exceptions within the chunks.forEach block. Some of the exceptions thrown are not caught within the Client bulk() method. Adds new params maxRetries and retryPause to saveAsElasticsearch method Revert "Adds new params maxRetries and retryPause to saveAsElasticsearch method" This exceeds the number of max params in scala style. So rely on it coming as cmdLine arg. This reverts commit 00c299f. Implements FluentBackoff Implements @setup for ElasticsearchWriters, restores formatting Restore indentation formatting on ES Bound constructors
regadas
force-pushed
the
elasticsearch-retries
branch
from
b7f6f64
to
7d3dd1f
Compare
1 task
nevillelyh
approved these changes
Apr 9, 2019
Codecov Report
@@ Coverage Diff @@
## master #1826 +/- ##
=========================================
Coverage ? 70.62%
=========================================
Files ? 190
Lines ? 5869
Branches ? 299
=========================================
Hits ? 4145
Misses ? 1724
Partials ? 0
Continue to review full report at Codecov.
|
regadas
force-pushed
the
elasticsearch-retries
branch
from
7d3dd1f
to
0689f2b
Compare
|
Woo! Glad to see this come in. Thank you everyone! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.