warn combine*/sum* transform usage, fix #1620 #1856
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nevillelyh
changed the title
nevillelyh
force-pushed
the
neville/combine
branch
from
8311880
to
b7c31f3
Compare
regadas
reviewed
Apr 18, 2019
| @@ -55,6 +56,8 @@ import scala.util.Try | |||
| /** Convenience functions for creating SCollections. */ | |||
| object SCollection { | |||
|
|
|||
| private[values] val logger = LoggerFactory.getLogger(this.getClass) | |||
There was a problem hiding this comment.
Suggested change
| private[values] val logger = LoggerFactory.getLogger(this.getClass) | |
| private[values] val Logger = LoggerFactory.getLogger(this.getClass) |
PairSCollectionFunctions is also lower case can you change it?
Codecov Report
@@ Coverage Diff @@
## master #1856 +/- ##
==========================================
+ Coverage 73.12% 73.15% +0.03%
==========================================
Files 191 191
Lines 5823 5838 +15
Branches 430 437 +7
==========================================
+ Hits 4258 4271 +13
- Misses 1565 1567 +2
Continue to review full report at Codecov.
|
regadas
approved these changes
Apr 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.