New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add table type to disambiguate spec and reference #1866
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1866 +/- ##
==========================================
- Coverage 71.93% 69.65% -2.28%
==========================================
Files 195 195
Lines 5953 5959 +6
Branches 326 346 +20
==========================================
- Hits 4282 4151 -131
- Misses 1671 1808 +137
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes in formating in BigQueryIO
make it hard to review the pull request.
Can you not mix reformating with actual changes ?
Also how come the formating changes anyway ? Scalafmt should take care of that automatically.
8b3ec6c
to
87ece5b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Fixes #1859