Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add table type to disambiguate spec and reference #1866

Merged
merged 4 commits into from Apr 26, 2019

Conversation

regadas
Copy link
Contributor

@regadas regadas commented Apr 24, 2019

Fixes #1859

@codecov
Copy link

codecov bot commented Apr 24, 2019

Codecov Report

Merging #1866 into master will decrease coverage by 2.27%.
The diff coverage is 25.92%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1866      +/-   ##
==========================================
- Coverage   71.93%   69.65%   -2.28%     
==========================================
  Files         195      195              
  Lines        5953     5959       +6     
  Branches      326      346      +20     
==========================================
- Hits         4282     4151     -131     
- Misses       1671     1808     +137
Impacted Files Coverage Δ
...cala/com/spotify/scio/bigquery/BigQueryTypes.scala 68.29% <ø> (ø) ⬆️
...n/scala/com/spotify/scio/bigquery/BigQueryIO.scala 21.37% <23.8%> (-2.44%) ⬇️
...otify/scio/bigquery/syntax/ScioContextSyntax.scala 50% <33.33%> (+3.84%) ⬆️
.../spotify/scio/bigquery/client/BigQueryConfig.scala 0% <0%> (-70.59%) ⬇️
...scala/com/spotify/scio/bigquery/client/Cache.scala 0% <0%> (-66.67%) ⬇️
.../spotify/scio/bigquery/BigQueryPartitionUtil.scala 0% <0%> (-58.98%) ⬇️
...scala/com/spotify/scio/bigquery/BigQueryUtil.scala 50% <0%> (-50%) ⬇️
...la/com/spotify/scio/bigquery/client/QueryOps.scala 0.82% <0%> (-47.11%) ⬇️
...com/spotify/scio/bigquery/types/BigQueryType.scala 36.84% <0%> (-21.06%) ⬇️
...la/com/spotify/scio/bigquery/client/TableOps.scala 0% <0%> (-19.77%) ⬇️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update efa6d1d...87ece5b. Read the comment docs.

Copy link
Contributor

@jto jto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes in formating in BigQueryIO make it hard to review the pull request.
Can you not mix reformating with actual changes ?

Also how come the formating changes anyway ? Scalafmt should take care of that automatically.

Copy link
Contributor

@jto jto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@regadas regadas merged commit f696b7e into spotify:master Apr 26, 2019
@regadas regadas deleted the feature/bq-table branch April 26, 2019 14:42
regadas added a commit that referenced this pull request Apr 28, 2019
jto pushed a commit that referenced this pull request Apr 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rework BigQuery storage read api default arguments
2 participants