Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix schema inference for scalar #1895

Merged
merged 4 commits into from May 7, 2019
Merged

Fix schema inference for scalar #1895

merged 4 commits into from May 7, 2019

Conversation

regadas
Copy link
Contributor

@regadas regadas commented May 3, 2019

Fixes #1894

@codecov
Copy link

codecov bot commented May 3, 2019

Codecov Report

Merging #1895 into master will decrease coverage by 1.77%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1895      +/-   ##
==========================================
- Coverage   72.61%   70.83%   -1.78%     
==========================================
  Files         200      200              
  Lines        6291     6285       -6     
  Branches      445      431      -14     
==========================================
- Hits         4568     4452     -116     
- Misses       1723     1833     +110
Impacted Files Coverage Δ
...core/src/main/scala/com/spotify/scio/sql/Sql.scala 88.29% <100%> (-0.25%) ⬇️
.../com/spotify/scio/schemas/SchemaMaterializer.scala 98.03% <100%> (+0.03%) ⬆️
...scala/com/spotify/scio/bigquery/BigQueryUtil.scala 50% <0%> (-50%) ⬇️
...la/com/spotify/scio/bigquery/client/QueryOps.scala 0.82% <0%> (-47.11%) ⬇️
.../spotify/scio/bigquery/client/BigQueryConfig.scala 41.17% <0%> (-29.42%) ⬇️
...scala/com/spotify/scio/bigquery/client/Cache.scala 62.96% <0%> (-18.52%) ⬇️
.../spotify/scio/bigquery/BigQueryPartitionUtil.scala 40% <0%> (-17.5%) ⬇️
...la/com/spotify/scio/bigquery/client/TableOps.scala 1.76% <0%> (-16.82%) ⬇️
...com/spotify/scio/bigquery/types/BigQueryType.scala 57.89% <0%> (-15.79%) ⬇️
...la/com/spotify/scio/bigquery/client/BigQuery.scala 28.94% <0%> (-10.53%) ⬇️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e5fea47...c73e336. Read the comment docs.

@regadas regadas merged commit 3751b91 into spotify:master May 7, 2019
@regadas regadas deleted the fix/1894 branch May 7, 2019 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sql interpolator throws NPE
2 participants