Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Query{n} for BeamSQL #1944

Merged
merged 7 commits into from May 29, 2019
Merged

Conversation

regadas
Copy link
Contributor

@regadas regadas commented May 29, 2019

No description provided.

@codecov
Copy link

codecov bot commented May 29, 2019

Codecov Report

Merging #1944 into master will decrease coverage by 5.01%.
The diff coverage is 15.34%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1944      +/-   ##
==========================================
- Coverage   72.58%   67.57%   -5.02%     
==========================================
  Files         202      214      +12     
  Lines        6326     6630     +304     
  Branches      430      452      +22     
==========================================
- Hits         4592     4480     -112     
- Misses       1734     2150     +416
Impacted Files Coverage Δ
...e/src/main/scala/com/spotify/scio/sql/Query8.scala 0% <0%> (ø)
...e/src/main/scala/com/spotify/scio/sql/Query9.scala 0% <0%> (ø)
...e/src/main/scala/com/spotify/scio/sql/Query6.scala 0% <0%> (ø)
...e/src/main/scala/com/spotify/scio/sql/Query5.scala 0% <0%> (ø)
.../src/main/scala/com/spotify/scio/sql/Query10.scala 0% <0%> (ø)
...e/src/main/scala/com/spotify/scio/sql/Query4.scala 0% <0%> (ø)
...e/src/main/scala/com/spotify/scio/sql/Query7.scala 0% <0%> (ø)
...n/scala/com/spotify/scio/sql/SqlInterpolator.scala 76% <100%> (-2.13%) ⬇️
...om/spotify/scio/sql/syntax/SCollectionSyntax.scala 100% <100%> (ø) ⬆️
...core/src/main/scala/com/spotify/scio/sql/Sql.scala 85.24% <100%> (-3.06%) ⬇️
... and 32 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0685587...7c5b3fe. Read the comment docs.

@regadas regadas marked this pull request as ready for review May 29, 2019 15:05
Copy link
Contributor

@jto jto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@regadas regadas merged commit a55ed52 into spotify:master May 29, 2019
@regadas regadas deleted the feature/n-query branch May 29, 2019 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants