Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Segregate and deprecate avro reflective records support #2300

Merged
merged 1 commit into from Oct 15, 2019

Conversation

jto
Copy link
Contributor

@jto jto commented Oct 10, 2019

This PR is an attempt to discourage the usage of reflective serialization in Avro and avoid its accidental use.

It separates "normal" IOs on GenericRecord and avro magic reflection based serialization. Back compatibility is preserved but a deprecation warning is issued.

@jto jto force-pushed the julient/genericrecordio-bound branch 2 times, most recently from 02a4e47 to 954d3b6 Compare October 10, 2019 14:47
Copy link
Contributor

@nevillelyh nevillelyh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM it's backwards compatible right?

@jto
Copy link
Contributor Author

jto commented Oct 10, 2019

Yes

@jto jto force-pushed the julient/genericrecordio-bound branch from 954d3b6 to 84b5a9a Compare October 11, 2019 09:07
@codecov
Copy link

codecov bot commented Oct 11, 2019

Codecov Report

Merging #2300 into master will increase coverage by <.01%.
The diff coverage is 83.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2300      +/-   ##
==========================================
+ Coverage   71.25%   71.25%   +<.01%     
==========================================
  Files         240      240              
  Lines        7743     7766      +23     
  Branches      353      352       -1     
==========================================
+ Hits         5517     5534      +17     
- Misses       2226     2232       +6
Impacted Files Coverage Δ
...m/spotify/scio/avro/syntax/SCollectionSyntax.scala 100% <100%> (ø) ⬆️
.../src/main/scala/com/spotify/scio/avro/AvroIO.scala 91.76% <100%> (+0.97%) ⬆️
...ro/src/main/scala/com/spotify/scio/avro/taps.scala 42.3% <50%> (+2.3%) ⬆️
...m/spotify/scio/avro/syntax/ScioContextSyntax.scala 83.33% <66.66%> (-16.67%) ⬇️
...main/scala/com/spotify/scio/util/BloomFilter.scala 93.47% <0%> (-0.73%) ⬇️
...com/spotify/scio/testing/SCollectionMatchers.scala 96.77% <0%> (-0.07%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a1111e8...84b5a9a. Read the comment docs.

@jto
Copy link
Contributor Author

jto commented Oct 15, 2019

@nevillelyh Can we merge this ?

@nevillelyh nevillelyh merged commit 003d1ce into master Oct 15, 2019
@nevillelyh nevillelyh deleted the julient/genericrecordio-bound branch October 15, 2019 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants