Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop FastEval #2622

Merged
merged 3 commits into from Jan 23, 2020
Merged

Drop FastEval #2622

merged 3 commits into from Jan 23, 2020

Conversation

regadas
Copy link
Contributor

@regadas regadas commented Jan 22, 2020

See #2623 for context.

@codecov
Copy link

codecov bot commented Jan 22, 2020

Codecov Report

Merging #2622 into master will decrease coverage by 1.47%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2622      +/-   ##
==========================================
- Coverage   68.24%   66.77%   -1.48%     
==========================================
  Files         208      208              
  Lines        7296     7289       -7     
  Branches      365      325      -40     
==========================================
- Hits         4979     4867     -112     
- Misses       2317     2422     +105
Impacted Files Coverage Δ
...l/src/main/scala/com/spotify/scio/sql/Query4.scala 0% <ø> (ø) ⬆️
...l/src/main/scala/com/spotify/scio/sql/Query3.scala 57.14% <ø> (ø) ⬆️
...l/src/main/scala/com/spotify/scio/sql/Query2.scala 94.44% <ø> (ø) ⬆️
.../src/main/scala/com/spotify/scio/sql/Query10.scala 0% <ø> (ø) ⬆️
...l/src/main/scala/com/spotify/scio/sql/Query1.scala 93.33% <ø> (ø) ⬆️
...l/src/main/scala/com/spotify/scio/sql/Query6.scala 0% <ø> (ø) ⬆️
...l/src/main/scala/com/spotify/scio/sql/Query5.scala 0% <ø> (ø) ⬆️
...l/src/main/scala/com/spotify/scio/sql/Query9.scala 0% <ø> (ø) ⬆️
...e/src/main/scala/com/spotify/scio/schemas/To.scala 94.2% <ø> (+0.78%) ⬆️
...l/src/main/scala/com/spotify/scio/sql/Query8.scala 0% <ø> (ø) ⬆️
... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 86f1fb7...fc89c2f. Read the comment docs.

@jto
Copy link
Contributor

jto commented Jan 23, 2020

👍

@regadas
Copy link
Contributor Author

regadas commented Jan 23, 2020

alright lets do this then

@regadas regadas marked this pull request as ready for review January 23, 2020 15:03
@regadas regadas added this to the 0.8.1 milestone Jan 23, 2020
@regadas regadas added the bug Something isn't working label Jan 23, 2020
@regadas regadas merged commit df4a0bf into spotify:master Jan 23, 2020
@regadas regadas deleted the chore/drop-fasteval branch January 23, 2020 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants