Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor update topByKey comments #2695

Merged
merged 1 commit into from Feb 19, 2020

Conversation

liufuyang
Copy link
Contributor

Make comment matching function definiation.

@codecov
Copy link

codecov bot commented Feb 19, 2020

Codecov Report

Merging #2695 into master will decrease coverage by 1.45%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2695      +/-   ##
==========================================
- Coverage    71.9%   70.45%   -1.46%     
==========================================
  Files         208      208              
  Lines        7308     7308              
  Branches      341      350       +9     
==========================================
- Hits         5255     5149     -106     
- Misses       2053     2159     +106
Impacted Files Coverage Δ
...spotify/scio/values/PairSCollectionFunctions.scala 96.89% <ø> (ø) ⬆️
...scala/com/spotify/scio/bigquery/client/Cache.scala 0% <0%> (-66.67%) ⬇️
.../spotify/scio/bigquery/BigQueryPartitionUtil.scala 0% <0%> (-52.5%) ⬇️
.../spotify/scio/bigquery/client/BigQueryConfig.scala 0% <0%> (-41.18%) ⬇️
...otify/scio/bigquery/syntax/ScioContextSyntax.scala 16.66% <0%> (-33.34%) ⬇️
.../scala/com/spotify/scio/bigquery/StorageUtil.scala 0% <0%> (-31.71%) ⬇️
...com/spotify/scio/bigquery/types/BigQueryType.scala 58.33% <0%> (-29.17%) ⬇️
...com/spotify/scio/bigquery/types/TypeProvider.scala 50.72% <0%> (-23.19%) ⬇️
...n/scala/com/spotify/scio/bigquery/BigQueryIO.scala 37.98% <0%> (-3.85%) ⬇️
...y/scio/values/PairSkewedSCollectionFunctions.scala 90.62% <0%> (-3.13%) ⬇️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3a1aeca...1fc7b66. Read the comment docs.

Copy link
Contributor

@regadas regadas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@nevillelyh nevillelyh merged commit 68632fb into spotify:master Feb 19, 2020
@liufuyang liufuyang deleted the fuyang-update-comments branch February 20, 2020 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants