Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #2761: make java Enum coder deterministic #2764

Merged
merged 3 commits into from Mar 13, 2020

Conversation

regadas
Copy link
Contributor

@regadas regadas commented Mar 11, 2020

Fixes #2761
Closes #2763

@codecov
Copy link

codecov bot commented Mar 11, 2020

Codecov Report

Merging #2764 into master will decrease coverage by 1.62%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #2764      +/-   ##
=========================================
- Coverage   72.13%   70.5%   -1.63%     
=========================================
  Files         215     215              
  Lines        7396    7398       +2     
  Branches      313     365      +52     
=========================================
- Hits         5335    5216     -119     
- Misses       2061    2182     +121
Impacted Files Coverage Δ
...com/spotify/scio/coders/instances/JavaCoders.scala 88.57% <100%> (+0.69%) ⬆️
...scala/com/spotify/scio/bigquery/client/Cache.scala 0% <0%> (-74.08%) ⬇️
.../spotify/scio/bigquery/BigQueryPartitionUtil.scala 0% <0%> (-52.5%) ⬇️
.../spotify/scio/bigquery/client/BigQueryConfig.scala 0% <0%> (-47.06%) ⬇️
.../scala/com/spotify/scio/bigquery/StorageUtil.scala 0% <0%> (-36.85%) ⬇️
...otify/scio/bigquery/syntax/ScioContextSyntax.scala 16.66% <0%> (-36.12%) ⬇️
...com/spotify/scio/bigquery/types/BigQueryType.scala 58.33% <0%> (-29.17%) ⬇️
...com/spotify/scio/bigquery/types/TypeProvider.scala 52.11% <0%> (-22.54%) ⬇️
...la/com/spotify/scio/bigquery/client/BigQuery.scala 28.2% <0%> (-10.26%) ⬇️
...la/com/spotify/scio/bigquery/client/TableOps.scala 0% <0%> (-10.11%) ⬇️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 55ba430...588164c. Read the comment docs.

@regadas regadas merged commit 9cd870d into spotify:master Mar 13, 2020
@regadas regadas deleted the fix/enum-coder branch March 13, 2020 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Java Enum coders are non deterministics
3 participants