Save metrics on close + close only once + check acc registration #296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 LGTM |
nevillelyh
reviewed
Oct 17, 2016
| val scioResult = new ScioResult(result, finalState, _accumulators.values.toSeq, pipeline) | ||
| val metricsLocation = optionsAs[ScioOptions].getMetricsLocation | ||
| if (metricsLocation != null && finalState.isCompleted) { | ||
| scioResult.saveMetrics(metricsLocation) |
There was a problem hiding this comment.
This only works with blocking runner? Should support non-blocking ones by setting a Future handler?
There was a problem hiding this comment.
yes. initially thought that supporting non blocking one would be an overkill. but it would be most consistent. need to move things around a bit.
ravwojdyla
changed the title
added 12 commits
October 18, 2016 10:43
Current coverage is 82.20% (diff: 87.50%)@@ master #296 diff @@
==========================================
Files 63 63
Lines 2320 2332 +12
Methods 2058 2058
Messages 0 0
Branches 262 274 +12
==========================================
+ Hits 1905 1917 +12
Misses 415 415
Partials 0 0
|
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.