Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: propagate PipelineOptions in job test #3026

Merged
merged 2 commits into from Jun 9, 2020

Conversation

regadas
Copy link
Contributor

@regadas regadas commented Jun 8, 2020

This has actually being discussed between us a couple weeks ago. Looking at the commit history this seems to be a mere artifact of how PipelineOptions were being propagated.

Fixes #3019

@regadas regadas force-pushed the 3019_propagate_pipelineopts branch from 116b410 to 9179f1b Compare June 8, 2020 11:50
@codecov
Copy link

codecov bot commented Jun 8, 2020

Codecov Report

Merging #3026 into master will decrease coverage by 2.65%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3026      +/-   ##
==========================================
- Coverage   72.73%   70.07%   -2.66%     
==========================================
  Files         225      225              
  Lines        7515     7512       -3     
  Branches      331      347      +16     
==========================================
- Hits         5466     5264     -202     
- Misses       2049     2248     +199     
Impacted Files Coverage Δ
.../src/main/scala/com/spotify/scio/ScioContext.scala 86.27% <100.00%> (-0.16%) ⬇️
...scala/com/spotify/scio/bigquery/client/Cache.scala 0.00% <0.00%> (-74.08%) ⬇️
.../spotify/scio/bigquery/client/BigQueryConfig.scala 0.00% <0.00%> (-70.59%) ⬇️
.../spotify/scio/bigquery/BigQueryPartitionUtil.scala 0.00% <0.00%> (-52.50%) ⬇️
...scala/com/spotify/scio/bigquery/BigQueryUtil.scala 50.00% <0.00%> (-50.00%) ⬇️
...otify/scio/bigquery/syntax/ScioContextSyntax.scala 19.35% <0.00%> (-41.94%) ⬇️
...la/com/spotify/scio/bigquery/client/QueryOps.scala 0.73% <0.00%> (-39.71%) ⬇️
.../scala/com/spotify/scio/bigquery/StorageUtil.scala 0.00% <0.00%> (-36.85%) ⬇️
...com/spotify/scio/bigquery/types/BigQueryType.scala 58.33% <0.00%> (-29.17%) ⬇️
...la/com/spotify/scio/bigquery/client/TableOps.scala 0.00% <0.00%> (-25.00%) ⬇️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c5b6296...23a01e6. Read the comment docs.

@jto jto merged commit b16a7e8 into spotify:master Jun 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TestPipeline on ScioContext created with empty Options
2 participants