Fix #311 BigQueryType.toTable should only take first child of field to get the type. #312
Conversation
| @@ -82,7 +82,7 @@ private[types] object TypeProvider { | |||
| case List(q"case class $name(..$fields) { ..$body }") => | |||
| val defSchema = q"override def schema: ${p(c, GModel)}.TableSchema = ${p(c, SType)}.schemaOf[$name]" | |||
| val defToPrettyString = q"override def toPrettyString(indent: Int = 0): String = ${p(c, s"$SBQ.types.SchemaUtil")}.toPrettyString(this.schema, ${name.toString}, indent)" | |||
| val fnTrait = tq"${newTypeName(s"Function${fields.size}")}[..${fields.flatMap(_.children)}, $name]" | |||
There was a problem hiding this comment.
Can you explain the difference here?
There was a problem hiding this comment.
Yeah, basically each param is a field that has children. For normal (non-default args), there is only one child which is the type. Default arguments have two children, where the first one is the type and the second is the default value. This just makes sure we always take the first child so we only get types.
There was a problem hiding this comment.
Are we throwing away the tail here then? Does that break default value behavior, e.g. does RecordWithDefault(10) still work without y?
There was a problem hiding this comment.
@nevillelyh Yeah, because this is only for generating the type of the Function trait, it's not replacing the case class definition. If you'd like I can add another test for this?
andrewsmartin
force-pushed
the
andrew/to-table-default
branch
from
f7f19b1
to
4296e04
Compare
…o get the type.
andrewsmartin
force-pushed
the
andrew/to-table-default
branch
from
4296e04
to
ee68f1c
Compare
|
👍 |
Current coverage is 81.87% (diff: 100%)@@ master #312 diff @@
==========================================
Files 64 64
Lines 2334 2334
Methods 2070 2079 +9
Messages 0 0
Branches 264 255 -9
==========================================
+ Hits 1910 1911 +1
+ Misses 424 423 -1
Partials 0 0
|
No description provided.