fix serialization struggles in SMB transform API #3342
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I fixed some of the serialization issues people have been seeing with the transform API when they try to extract the
Read
into a non lazy variable. I did this by eagerly converting theRead
into aBucketedInput
right away so we're not passing through non-serializable members ofRead
such as Schema/CodecFactory.Tested it out in unit test, DirectRunner & DataflowRunner and the new API passes serialization each time 馃憤
I also updated the transform unit test to use the same assertions that the Sink does -- i.e. checking that the elements have all been correctly rehashed into the new bucketing scheme.