Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add nullCoder on Record and Disjunction coders #3349

Merged
merged 1 commit into from Sep 25, 2020

Conversation

regadas
Copy link
Contributor

@regadas regadas commented Sep 24, 2020

No description provided.

@codecov
Copy link

codecov bot commented Sep 24, 2020

Codecov Report

Merging #3349 into master will decrease coverage by 2.54%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3349      +/-   ##
==========================================
- Coverage   72.70%   70.15%   -2.55%     
==========================================
  Files         234      234              
  Lines        7708     7710       +2     
  Branches      333      348      +15     
==========================================
- Hits         5604     5409     -195     
- Misses       2104     2301     +197     
Impacted Files Coverage Δ
...la/com/spotify/scio/coders/CoderMaterializer.scala 100.00% <100.00%> (ø)
...scala/com/spotify/scio/bigquery/client/Cache.scala 0.00% <0.00%> (-74.08%) ⬇️
.../spotify/scio/bigquery/client/BigQueryConfig.scala 0.00% <0.00%> (-70.59%) ⬇️
.../spotify/scio/bigquery/BigQueryPartitionUtil.scala 0.00% <0.00%> (-52.50%) ⬇️
...scala/com/spotify/scio/bigquery/BigQueryUtil.scala 50.00% <0.00%> (-50.00%) ⬇️
...otify/scio/bigquery/syntax/ScioContextSyntax.scala 21.87% <0.00%> (-40.63%) ⬇️
...la/com/spotify/scio/bigquery/client/QueryOps.scala 0.73% <0.00%> (-39.71%) ⬇️
.../scala/com/spotify/scio/bigquery/StorageUtil.scala 0.00% <0.00%> (-36.85%) ⬇️
...com/spotify/scio/bigquery/types/BigQueryType.scala 58.33% <0.00%> (-29.17%) ⬇️
...la/com/spotify/scio/bigquery/client/TableOps.scala 0.00% <0.00%> (-25.00%) ⬇️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 470c1ea...f29df81. Read the comment docs.

@jto jto merged commit 7232886 into spotify:master Sep 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants