Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix scio version warning in tests #3489

Merged
merged 6 commits into from Nov 19, 2020
Merged

Conversation

regadas
Copy link
Contributor

@regadas regadas commented Nov 18, 2020

No description provided.

@codecov
Copy link

codecov bot commented Nov 18, 2020

Codecov Report

Merging #3489 (537d7d6) into master (828dca9) will decrease coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3489      +/-   ##
==========================================
- Coverage   67.94%   67.90%   -0.04%     
==========================================
  Files         250      250              
  Lines        7513     7513              
  Branches      367      358       -9     
==========================================
- Hits         5105     5102       -3     
- Misses       2408     2411       +3     
Impacted Files Coverage Δ
.../src/main/scala/com/spotify/scio/VersionUtil.scala 68.29% <100.00%> (-9.76%) ⬇️
.../spotify/scio/bigquery/syntax/TableRowSyntax.scala 37.03% <0.00%> (+3.70%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 828dca9...537d7d6. Read the comment docs.

@regadas regadas added the bug Something isn't working label Nov 19, 2020
@regadas regadas merged commit 79b9886 into spotify:master Nov 19, 2020
@regadas regadas deleted the fix_version_check branch November 19, 2020 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant