Migrate to magnolia1 #4422
Merged
Migrate to magnolia1 #4422
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #4422 +/- ##
==========================================
- Coverage 60.50% 60.48% -0.03%
==========================================
Files 275 275
Lines 9882 9882
Branches 444 438 -6
==========================================
- Hits 5979 5977 -2
- Misses 3903 3905 +2
Continue to review full report at Codecov.
|
kellen
approved these changes
Jul 6, 2022
scio-macros/src/main/scala/com/spotify/scio/MagnoliaMacros.scala
Outdated
Show resolved
Hide resolved
scio-macros/src/main/scala/com/spotify/scio/MagnoliaMacros.scala
Outdated
Show resolved
Hide resolved
|
|
||
| type Typeclass[T] = Coder[T] | ||
|
|
||
| def combine[T](ctx: CaseClass[Coder, T]): Coder[T] = |
There was a problem hiding this comment.
What's the logic on this rename?
There was a problem hiding this comment.
magnolia1 changed its API:
combine->joindispatch->split
The magnolia macro expects those functions to be defined. This code shouldn't be used directly by users anyway
clairemcginty
pushed a commit
that referenced
this pull request
Oct 14, 2022
* Migrate to magnolia1 * Update doc links * Remove magnolia1 annotations * Disable formatting block * Improve macro transformation to remove annotations * Prefix type param matchers with tp * Update to released version of magnolify
clairemcginty
pushed a commit
that referenced
this pull request
Oct 14, 2022
* Migrate to magnolia1 * Update doc links * Remove magnolia1 annotations * Disable formatting block * Improve macro transformation to remove annotations * Prefix type param matchers with tp * Update to released version of magnolify
RustedBones
added a commit
that referenced
this pull request
Nov 22, 2022
This reverts commit 84cff3f.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #4420