Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve style of REPL test #4629

Merged
merged 1 commit into from
Dec 12, 2022
Merged

Improve style of REPL test #4629

merged 1 commit into from
Dec 12, 2022

Conversation

shnapz
Copy link
Contributor

@shnapz shnapz commented Dec 8, 2022

Adding a style improvement for the previous PR

@codecov
Copy link

codecov bot commented Dec 8, 2022

Codecov Report

Merging #4629 (59f0b23) into main (e5e8773) will decrease coverage by 7.55%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #4629      +/-   ##
==========================================
- Coverage   68.23%   60.67%   -7.56%     
==========================================
  Files         269      286      +17     
  Lines        8261    10447    +2186     
  Branches      693      693              
==========================================
+ Hits         5637     6339     +702     
- Misses       2624     4108    +1484     
Impacted Files Coverage Δ
...src/main/scala/com/spotify/scio/coders/Coder.scala 85.39% <0.00%> (-0.45%) ⬇️
.../scio/extra/sparkey/instances/SparkeySetBase.scala 0.00% <0.00%> (ø)
...scala/com/spotify/scio/elasticsearch/package.scala 100.00% <0.00%> (ø)
...om/spotify/scio/coders/instances/TupleCoders.scala 32.36% <0.00%> (ø)
...coders/instances/kryo/JTraversableSerializer.scala 82.60% <0.00%> (ø)
...om/spotify/scio/elasticsearch/CoderInstances.scala 42.42% <0.00%> (ø)
...om/spotify/scio/elasticsearch/CoderInstances.scala 100.00% <0.00%> (ø)
...scala/com/spotify/scio/elasticsearch/package.scala 100.00% <0.00%> (ø)
...scala/com/spotify/scio/elasticsearch/package.scala 100.00% <0.00%> (ø)
...m/spotify/scio/elasticsearch/ElasticsearchIO.scala 34.48% <0.00%> (ø)
... and 8 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@shnapz shnapz merged commit d15477d into main Dec 12, 2022
@shnapz shnapz deleted the FixRepl branch December 12, 2022 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants