Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update SBF docs, fixes #4528 #4693

Merged
merged 2 commits into from
Feb 3, 2023
Merged

Update SBF docs, fixes #4528 #4693

merged 2 commits into from
Feb 3, 2023

Conversation

kellen
Copy link
Contributor

@kellen kellen commented Feb 3, 2023

Updates ScalableBloomFilter docs to more completely and correctly describe its behavior.

See this gist for code to estimate false positive probability, capacity, and size: https://gist.github.com/kellen/38f47f84bd02c7d64d678add5d8b79f2

@codecov
Copy link

codecov bot commented Feb 3, 2023

Codecov Report

Merging #4693 (8fda0ed) into main (470c80f) will not change coverage.
The diff coverage is n/a.

❗ Current head 8fda0ed differs from pull request most recent head edea798. Consider uploading reports for the commit edea798 to get more accurate results

@@           Coverage Diff           @@
##             main    #4693   +/-   ##
=======================================
  Coverage   60.64%   60.64%           
=======================================
  Files         286      286           
  Lines       10453    10453           
  Branches      694      694           
=======================================
  Hits         6339     6339           
  Misses       4114     4114           
Impacted Files Coverage Δ
...src/main/scala/com/spotify/scio/coders/Coder.scala 85.39% <ø> (ø)
...spotify/scio/hash/MutableScalableBloomFilter.scala 95.58% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@kellen kellen merged commit 2498648 into main Feb 3, 2023
@kellen kellen deleted the kellen/mbsf-docs branch February 3, 2023 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants