Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Parquet-SplittableDoFn opt-in, not opt-out #4700

Merged
merged 1 commit into from
Feb 6, 2023

Conversation

clairemcginty
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Feb 6, 2023

Codecov Report

Merging #4700 (a70d43e) into main (1e58385) will increase coverage by 0.29%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #4700      +/-   ##
==========================================
+ Coverage   60.63%   60.93%   +0.29%     
==========================================
  Files         286      286              
  Lines       10457    10457              
  Branches      667      667              
==========================================
+ Hits         6341     6372      +31     
+ Misses       4116     4085      -31     
Impacted Files Coverage Δ
...y/scio/parquet/read/ParquetReadConfiguration.scala 100.00% <100.00%> (ø)
...spotify/scio/parquet/read/ReadSupportFactory.scala 33.33% <0.00%> (-66.67%) ⬇️
.../com/spotify/scio/parquet/read/ParquetReadFn.scala 83.01% <0.00%> (-2.84%) ⬇️
...y/scio/values/PairSkewedSCollectionFunctions.scala 95.94% <0.00%> (+2.70%) ⬆️
...ify/scio/parquet/tensorflow/ParquetExampleIO.scala 88.88% <0.00%> (+7.40%) ⬆️
...la/com/spotify/scio/parquet/GcsConnectorUtil.scala 21.87% <0.00%> (+9.37%) ⬆️
.../com/spotify/scio/parquet/avro/ParquetAvroIO.scala 84.84% <0.00%> (+11.11%) ⬆️
...com/spotify/scio/parquet/types/ParquetTypeIO.scala 98.59% <0.00%> (+22.53%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@clairemcginty clairemcginty merged commit 96c9379 into main Feb 6, 2023
@clairemcginty clairemcginty deleted the parquet-sdf-default branch February 6, 2023 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants