Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid using outputfield cache #4701

Merged
merged 1 commit into from
Feb 9, 2023
Merged

Avoid using outputfield cache #4701

merged 1 commit into from
Feb 9, 2023

Conversation

shnapz
Copy link
Contributor

@shnapz shnapz commented Feb 9, 2023

Removed call to ClosureCleaner that potentially can cause race condition

@codecov
Copy link

codecov bot commented Feb 9, 2023

Codecov Report

Merging #4701 (276e6af) into main (96c9379) will increase coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #4701      +/-   ##
==========================================
+ Coverage   60.91%   60.93%   +0.01%     
==========================================
  Files         286      286              
  Lines       10457    10457              
  Branches      667      667              
==========================================
+ Hits         6370     6372       +2     
+ Misses       4087     4085       -2     
Impacted Files Coverage Δ
...n/scala/com/spotify/scio/coders/DerivedCoder.scala 97.43% <ø> (ø)
...y/scio/values/PairSkewedSCollectionFunctions.scala 95.94% <0.00%> (+2.70%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@shnapz shnapz merged commit 6cbb941 into main Feb 9, 2023
@shnapz shnapz deleted the FixClosureCleanerProblem branch February 9, 2023 18:18
@RustedBones
Copy link
Contributor

Nice. Glad we can keep the error message

farzad-sedghi pushed a commit to farzad-sedghi/scio that referenced this pull request Mar 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants