update smb multi join code gen to the latest #4702
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shnapz
reviewed
Feb 9, 2023
| @@ -57,7 +57,7 @@ def mkCogroupFnRetVal(n, aWrapper=None, otherWrapper=None): | |||
|
|
|||
| def mkTransformFnRetVal(n, aWrapper=None, otherWrapper=None): | |||
| vals = fnRetValHelper(n, aWrapper, otherWrapper) | |||
| return 'SortedBucketScioContext#SortMergeTransformReadBuilder[KEY, (%s)]' % ', '.join(vals) | |||
| return 'SortedBucketScioContext#SortMergeTransformReadBuilder[KEY, KEY, Void, (%s)]' % ', '.join(vals) | |||
There was a problem hiding this comment.
this is what was changed manually when adding the secondary SMB sort key I believe
RustedBones
approved these changes
Feb 10, 2023
no after formatting both sides have zero diffs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
updated the code generator for
SMBMultiJoin.scalato reflect the latest manual changes