Set default JdkAddOpenModules for Java 17 #4710
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #4710 +/- ##
==========================================
- Coverage 60.94% 60.91% -0.03%
==========================================
Files 286 286
Lines 10467 10472 +5
Branches 750 758 +8
==========================================
Hits 6379 6379
- Misses 4088 4093 +5
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
shnapz
reviewed
Feb 14, 2023
| @@ -20,7 +20,7 @@ jobs: | |||
| uses: actions/setup-java@v3 | |||
| with: | |||
| distribution: temurin | |||
| java-version: 11 | |||
| java-version: 17 | |||
There was a problem hiding this comment.
don't we want to run it in both 11 and 17?
There was a problem hiding this comment.
Ideally yes, but not sure it's worth the extra Dataflow cost... imo since our release config still targets Java 8 I think we're pretty well-covered as far as writing compatible code. wdyt?
regadas
approved these changes
Feb 17, 2023
farzad-sedghi
pushed a commit
to farzad-sedghi/scio
that referenced
this pull request
Mar 6, 2023
* Set JdkAddOpenModules for Java 17 * Check that options are null * Run Dataflow IT test on 17
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Required for Kryo coders to function.
If users sets the
JdkAddOpenModulesoption in their job specifically, it will completely override these default options from Scio.