Add opt-in Logical type support to 0.11.x branch #4792
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Reproduce SpecificRecords/logicalType bug * Fix bug * Cleanup test * logical types must be added from worker VM, not launcher * Fix for both reads and writes * cleanup * Don't set supplier if user has explicitly configured one * Test for custom logical type provider * Pass dataModel to AvroParquetWriter.Builder * Only override .withDataModel if Configuration key exists * Isolate SpecificData instances * fix test * update copyright year * cleanup * Add support for scio-smb Parquet writes * Manage config defaults via core-site.xml * Fix formatting * Should be a standalone class * add test * +header * newline * Add remaining Converters * simplify SpecificData creation * Correctly encode logical types in GenericRecord * remove unused import
* Make logical type support for Parquet-Avro opt-in * Update documentation * conf->jobConf * scalafmt * Update scio-parquet/src/main/scala/com/spotify/scio/parquet/avro/ParquetAvroIO.scala Co-authored-by: Michel Davit <micheld@spotify.com> * Add parens --------- Co-authored-by: Michel Davit <micheld@spotify.com>
farzad-sedghi
approved these changes
May 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cherry-picked from #4772, #4782