Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update beam-runners-core-construction-java, ... to 2.49.0 #4927

Conversation

scala-steward
Copy link
Contributor

About this PR

📦 Updates

  • org.apache.beam:beam-runners-core-construction-java
  • org.apache.beam:beam-runners-direct-java
  • org.apache.beam:beam-runners-flink-1.16
  • org.apache.beam:beam-runners-google-cloud-dataflow-java
  • org.apache.beam:beam-runners-spark-3
  • org.apache.beam:beam-sdks-java-core
  • org.apache.beam:beam-sdks-java-extensions-avro
  • org.apache.beam:beam-sdks-java-extensions-google-cloud-platform-core
  • org.apache.beam:beam-sdks-java-extensions-protobuf
  • org.apache.beam:beam-sdks-java-extensions-sketching
  • org.apache.beam:beam-sdks-java-extensions-sorter
  • org.apache.beam:beam-sdks-java-extensions-sql
  • org.apache.beam:beam-sdks-java-extensions-zetasketch
  • org.apache.beam:beam-sdks-java-io-google-cloud-platform
  • org.apache.beam:beam-sdks-java-io-hadoop-common
  • org.apache.beam:beam-sdks-java-io-hadoop-format
  • org.apache.beam:beam-sdks-java-io-jdbc
  • org.apache.beam:beam-sdks-java-io-neo4j
  • org.apache.beam:beam-sdks-java-io-redis

from 2.48.0 to 2.49.0

Usage

Please merge!

I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.

If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.

Configure Scala Steward for your repository with a .scala-steward.conf file.

Have a fantastic day writing Scala!

🔍 Files still referring to the old version number

The following files still refer to the old version number (2.48.0).
You might want to review and update them manually.

build.sbt
site/src/main/paradox/releases/Apache-Beam.md
⚙ Adjust future updates

Add this to your .scala-steward.conf file to ignore future updates of this dependency:

updates.ignore = [ { groupId = "org.apache.beam" } ]

Or, add this to slow down future updates of this dependency:

dependencyOverrides = [{
  pullRequests = { frequency = "30 days" },
  dependency = { groupId = "org.apache.beam" }
}]
labels: library-update, early-semver-minor, semver-spec-minor, old-version-remains, commit-count:1

throw new RuntimeException(msg)
}

val factory = new AvroDatumFactory(clazz) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure we should provide this as default.

If user rely on AvroHugger, they should probably defined their own AvroDatumFactory as this one. I think now, most avro IOs will also require a custom DatumReaderFactory/DatumWriterFactory because of invalid schema loading.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was never possible to use the avro hugger generated classes in the scio SpecificRecordIO because beam automatically calls ReflectData.get().getSchema(recordClass) that throws an AvroRuntimeException here

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd be more in favor of this change for the avro coders: e1dd5ea

@RustedBones RustedBones force-pushed the update/beam-runners-core-construction-java-2.49.0 branch from e5fb5ba to 7273d4f Compare July 19, 2023 09:27
@codecov
Copy link

codecov bot commented Jul 19, 2023

Codecov Report

Merging #4927 (052722a) into main (ee85495) will increase coverage by 0.02%.
The diff coverage is 100.00%.

❗ Current head 052722a differs from pull request most recent head 7273d4f. Consider uploading reports for the commit 7273d4f to get more accurate results

@@            Coverage Diff             @@
##             main    #4927      +/-   ##
==========================================
+ Coverage   62.96%   62.98%   +0.02%     
==========================================
  Files         282      282              
  Lines       10641    10648       +7     
  Branches      779      789      +10     
==========================================
+ Hits         6700     6707       +7     
  Misses       3941     3941              
Impacted Files Coverage Δ
...com/spotify/scio/coders/instances/AvroCoders.scala 86.66% <100.00%> (+2.45%) ⬆️

@RustedBones RustedBones merged commit db1329b into spotify:main Jul 20, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants