-
Notifications
You must be signed in to change notification settings - Fork 510
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update beam-runners-core-construction-java, ... to 2.49.0 #4927
Update beam-runners-core-construction-java, ... to 2.49.0 #4927
Conversation
throw new RuntimeException(msg) | ||
} | ||
|
||
val factory = new AvroDatumFactory(clazz) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure we should provide this as default.
If user rely on AvroHugger, they should probably defined their own AvroDatumFactory
as this one. I think now, most avro IOs will also require a custom DatumReaderFactory/DatumWriterFactory
because of invalid schema loading.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It was never possible to use the avro hugger generated classes in the scio SpecificRecordIO
because beam automatically calls ReflectData.get().getSchema(recordClass)
that throws an AvroRuntimeException
here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd be more in favor of this change for the avro coders: e1dd5ea
e5fb5ba
to
7273d4f
Compare
Codecov Report
@@ Coverage Diff @@
## main #4927 +/- ##
==========================================
+ Coverage 62.96% 62.98% +0.02%
==========================================
Files 282 282
Lines 10641 10648 +7
Branches 779 789 +10
==========================================
+ Hits 6700 6707 +7
Misses 3941 3941
|
About this PR
📦 Updates
from
2.48.0
to2.49.0
Usage
✅ Please merge!
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a
.scala-steward.conf
file.Have a fantastic day writing Scala!
🔍 Files still referring to the old version number
The following files still refer to the old version number (2.48.0).
You might want to review and update them manually.
⚙ Adjust future updates
Add this to your
.scala-steward.conf
file to ignore future updates of this dependency:Or, add this to slow down future updates of this dependency: