Fix compiler warnings #4934
Merged
Fix compiler warnings #4934
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RustedBones
force-pushed
the
fix-compiler-warnings
branch
from
9f5d377
to
f3f80a7
Compare
kellen
approved these changes
Jul 24, 2023
|
Seems to have broken some tests ;) |
|
Yes. will unset draft as soon as those are fixed. |
RustedBones
force-pushed
the
fix-compiler-warnings
branch
from
5347c37
to
f764923
Compare
RustedBones
commented
Jul 31, 2023
| @@ -22,7 +22,7 @@ import com.spotify.scio.coders.Coder | |||
| import com.google.common.{hash => g} | |||
| import org.apache.beam.sdk.coders.CustomCoder | |||
|
|
|||
| class GuavaBloomFilterCoder[T](implicit val funnel: g.Funnel[T]) | |||
| class GuavaBloomFilterCoder[T](implicit val funnel: g.Funnel[_ >: T]) | |||
There was a problem hiding this comment.
BLoomFilter[String] can be created from a Funnel[CharSequence] (expected funnel is <? extends T>).
Associated coder should also be able to be constructed with such funnel
Codecov Report
@@ Coverage Diff @@
## v0.14.x #4934 +/- ##
===========================================
+ Coverage 62.98% 63.23% +0.25%
===========================================
Files 282 284 +2
Lines 10648 10669 +21
Branches 789 783 -6
===========================================
+ Hits 6707 6747 +40
+ Misses 3941 3922 -19
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix compiler warnings
IsJavaBeanevidence)@unchekedannotations in pattern matching when required