Drop collection compat shim in favor of official scala-collection-compat #5069
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RustedBones
force-pushed
the
remove-collection-compat-shim
branch
from
577f150
to
bfb8db5
Compare
RustedBones
force-pushed
the
remove-collection-compat-shim
branch
2 times, most recently
from
3844f52
to
78df5c5
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #5069 +/- ##
==========================================
- Coverage 63.57% 63.57% -0.01%
==========================================
Files 295 295
Lines 10928 10932 +4
Branches 731 755 +24
==========================================
+ Hits 6948 6950 +2
- Misses 3980 3982 +2 ☔ View full report in Codecov by Sentry. |
RustedBones
force-pushed
the
remove-collection-compat-shim
branch
from
e641a4f
to
a16fbdb
Compare
clairemcginty
approved these changes
Jan 17, 2024
RustedBones
commented
Jan 23, 2024
Comment on lines
+33
to
+34
| case arg if arg.getClass == JListWrapperClass => | ||
| val underlying = JListWrapperClass |
There was a problem hiding this comment.
Checking against the wrong class. This must be JIterableWrapperClass
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.