Upgrade Parquet to 0.13.1 #5175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clairemcginty
force-pushed
the
parquet-1.13.1-logical
branch
from
971d4a8
to
db70d18
Compare
clairemcginty
commented
Jan 17, 2024
| @@ -98,7 +98,7 @@ class TestWriterUtils extends AnyFlatSpec with Matchers with BeforeAndAfterAll { | |||
| assertColumn( | |||
| columnEncodings(4), | |||
| "account_status", | |||
| hasBloomFilter = true, | |||
| hasBloomFilter = false, | |||
There was a problem hiding this comment.
bloom filters are no longer generated when all pages of a column have a dictionary encoding, see: apache/parquet-java@4e9e79c
clairemcginty
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Parquet 1.13.1 supports logical types in Avro without us needing to inject a custom DataSupplier 🙌