Add Scalafix rule for LogicalTypeSupplier removal #5178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clairemcginty
commented
Jan 17, 2024
scalafix/input-0_14/src/main/scala/fix/v0_14_0/FixLogicalTypeSuppliers.scala
Show resolved
Hide resolved
clairemcginty
commented
Jan 17, 2024
scalafix/rules/src/main/scala/fix/v0_14_0/FixLogicalTypeSupplier.scala
Outdated
Show resolved
Hide resolved
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5178 +/- ##
=======================================
Coverage 62.63% 62.64%
=======================================
Files 301 301
Lines 10845 10845
Branches 768 768
=======================================
+ Hits 6793 6794 +1
+ Misses 4052 4051 -1 ☔ View full report in Codecov by Sentry. |
RustedBones
force-pushed
the
logical-type-scalafix
branch
from
3bec089
to
cbd11fb
Compare
RustedBones
reviewed
Jan 30, 2024
Comment on lines
+35
to
+40
| term.symbol.info | ||
| .map(_.signature) | ||
| .collect { case MethodSignature(_, _, returnedType) => returnedType } | ||
| .collect { case TypeRef(_, sym, tpe :: Nil) if JavaClassMatcher.matches(sym) => tpe } | ||
| .collect { case TypeRef(_, sym, _) => sym } | ||
| .exists(LogicalTypeSupplierMatcher.matches) |
There was a problem hiding this comment.
This works when class is stored in a val.
Unfortunately for this shift, since the type is removed, the val needs to also go away but that's kind of hard to do.
There was a problem hiding this comment.
yeah, I didn't try to implement that due to the complexity
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.