Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use new vendored Guava version #5195

Merged
merged 1 commit into from
Jan 23, 2024
Merged

Conversation

clairemcginty
Copy link
Contributor

Beam 2.53.0 uses vendored Guava 32.1.2 (ex). This PR updates Scio to match

Copy link

codecov bot commented Jan 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8962386) 63.05% compared to head (d975ca0) 63.06%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5195   +/-   ##
=======================================
  Coverage   63.05%   63.06%           
=======================================
  Files         300      300           
  Lines       10947    10947           
  Branches      740      740           
=======================================
+ Hits         6903     6904    +1     
+ Misses       4044     4043    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@regadas regadas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@clairemcginty clairemcginty merged commit d452e94 into main Jan 23, 2024
11 checks passed
@clairemcginty clairemcginty deleted the update-vendor-guava-version branch January 23, 2024 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants