Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require import for kryo implicit fallback coder #5199

Merged
merged 4 commits into from
Jan 24, 2024
Merged

Conversation

RustedBones
Copy link
Contributor

  • Only define coders in dedicated trait and avoid forward coder usage (trait mixed in Coder calling Coder.xxx method)
  • prefer lazy val for non-parametrized coders
  • Add new Sparkey coders required for testing
  • Move implicit coder fallback into com.spotify.scio.coders.kyro

Copy link

codecov bot commented Jan 24, 2024

Codecov Report

Attention: 7 lines in your changes are missing coverage. Please review.

Comparison is base (964aad7) 63.06% compared to head (b1a9946) 62.56%.
Report is 1 commits behind head on main.

Files Patch % Lines
...om/spotify/scio/coders/instances/ScalaCoders.scala 78.94% 4 Missing ⚠️
...spotify/scio/coders/instances/AlgebirdCoders.scala 60.00% 2 Missing ⚠️
...tify/scio/coders/extra/sparkey/SparkeyCoders.scala 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5199      +/-   ##
==========================================
- Coverage   63.06%   62.56%   -0.51%     
==========================================
  Files         300      301       +1     
  Lines       10947    10807     -140     
  Branches      740      764      +24     
==========================================
- Hits         6904     6761     -143     
- Misses       4043     4046       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@@ -193,6 +193,11 @@ object SortMergeBucketTransformExample {
def pipeline(cmdLineArgs: Array[String]): ScioContext = {
val (sc, args) = ContextAndArgs(cmdLineArgs)

implicit val coderUserData: Coder[GenericRecord] =
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it is too bad that the SMB read/transform APIs now require Coders just to execute the isTest path :( But I can't see a way around that.

@RustedBones RustedBones merged commit 91d4d80 into main Jan 24, 2024
11 checks passed
@RustedBones RustedBones deleted the kryo-semi-auto branch January 24, 2024 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants