data_files not included in sdist

[ravwojdyla]

In py2.6 and still in 2.7 sdist may not include data_files from setup.py in source distribution which make some file unreachable during install process (including bash completion and license file).

@wouterdebie how do you produce tarballs available in pypi, I can see they have license and bash completion but I can't reproduce this via python setup.py sdist?

To solve the problem, let's add MANIFEST.in and add all required files including:

• bash completion
• license

Also since by default sdist includes all test/test* files, which at the moment includes two files (out of many test files), let's decided on either including all test files (via manifest) or not. I think we shouldn't include test files, what do you think @wouterdebie ?

[wouterdebie]

I run python setup.py sdist upload. I'll give you the credentials tomorrow if you don't have them.
I do like tests in the package, so I can see how code is used after installing through pip.

[ravwojdyla]

I see, I can't reproduce it ;(
See: https://gist.github.com/ravwojdyla/1fe14bb3c37be07e058c

Couple of problems from above run:

• no license
• bash completion is not there
• only two test files are there - because the rest doesn't follow default naming convention test/test*:

hard linking test/test.py -> snakebite-2.4.5/test
hard linking test/test_test.py -> snakebite-2.4.5/test

We can put all the test files in the tarball - but I think we need to do that in the MANIFEST, PR #74
excludes test files completely. So would like them to be included because them user can lookup the tests code, we are not talking about actually running tests right? If user would like to run tests from sdist then we need to include all the stuff to actually make it possible - like setup-env script. (?)

[wouterdebie]

I was thinking to include the test files but only for reference and not to run tests, but after thinking about it, just leave them out, because it might be too confusing. Tests that you can't run..

[ravwojdyla]

I agree completely - current PR #74 is valid and ready to merge, it would be nice to validate this sdist output tho. So let's first validate sdist and then decide on merging manifest.