This repository has been archived by the owner on Jul 12, 2023. It is now read-only.
add CONTRIBUTING.md with log level guidelines #212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
For reference, the k8s logging guidelines: https://github.com/kubernetes/community/blob/master/contributors/devel/logging.md |
CONTRIBUTING.md
Outdated
| responding to API calls. | ||
| * `debug` for other occurrences, uncertain significance but eventually | ||
| helpful in troubleshooting; e.g. workflow instance state transitions. | ||
|
|
|
👍 |
bergman
reviewed
May 30, 2017
CONTRIBUTING.md
Outdated
| not inevitably lead to one.) | ||
| * `info` for other significant occurrences; e.g. starting and stopping, | ||
| responding to API calls. | ||
| * `debug` for other occurrences, uncertain significance but eventually |
There was a problem hiding this comment.
Is eventually the right word here? I would go for possibly or similar non-promising words.
bergman
reviewed
May 30, 2017
README.md
Outdated
| @@ -32,14 +32,15 @@ easily be added. | |||
|
|
|||
| ## Key concepts | |||
|
|
|||
| The key type of information that Styx concerns itself with are Workflows. A Workflow is either | |||
| The key concept that Styx concerns itself with are Workflows. A Workflow is either | |||
There was a problem hiding this comment.
I think the … are Workflows should be … is Workflows.
|
Please reflow the paragraphs that you changed, some lines are too long and some too short. |
Codecov Report
@@ Coverage Diff @@
## master #212 +/- ##
============================================
- Coverage 69.25% 69.23% -0.03%
+ Complexity 861 860 -1
============================================
Files 111 111
Lines 3689 3689
Branches 207 207
============================================
- Hits 2555 2554 -1
Misses 1064 1064
- Partials 70 71 +1 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.