Skip to content
This repository has been archived by the owner on Jul 12, 2023. It is now read-only.

use 2 series #302

Closed
wants to merge 1 commit into from
Closed

use 2 series #302

wants to merge 1 commit into from

Conversation

honnix
Copy link
Member

@honnix honnix commented Oct 16, 2017

@fabriziodemaria @danielnorberg Let's take it as a separated PR.

@danielnorberg
Copy link
Contributor

okhttp 2 is obsolete tho: https://github.com/square/okhttp/blob/master/CHANGELOG.md#version-300-rc1

This release obsoletes OkHttp 2.x, and all code that uses OkHttp's com.squareup.okhttp package should upgrade to the okhttp3 package. Libraries that depend on OkHttp should upgrade quickly to prevent applications from being stuck on the old version.

@honnix
Copy link
Member Author

honnix commented Oct 17, 2017

Yeah unfortunately. But we probably want to go with Apollo.

@danielnorberg
Copy link
Contributor

We should submit a PR to apollo to upgrade to okhttp3 as well I guess.

@honnix
Copy link
Member Author

honnix commented Oct 17, 2017

@danielnorberg feel free to merge this if it's OK.

@honnix
Copy link
Member Author

honnix commented Oct 19, 2017

spotify/apollo#220 :D

@danielnorberg
Copy link
Contributor

@honnix thanks =)

@honnix
Copy link
Member Author

honnix commented Oct 26, 2017

OK to merge for now? This jar is now included for nothing.

@danielnorberg
Copy link
Contributor

But then we end up with an explicit dependency on the obsolete okhttp...

@honnix
Copy link
Member Author

honnix commented Oct 26, 2017

That's true. I think there is little chance that Apollo 1.x will upgrade to okhttp3 spotify/apollo#224

If we want to use okhttp3 explicitly here, let's fix the imported packages.

@honnix
Copy link
Member Author

honnix commented Oct 26, 2017

#316

@danielnorberg
Copy link
Contributor

I interpreted spotify/apollo#220 (comment) as upgrading to okhttp3 being positively considered for Apollo 1.x as well

@honnix
Copy link
Member Author

honnix commented Nov 1, 2017

in favor of #316

@honnix honnix closed this Nov 1, 2017
@honnix honnix deleted the no-okhttp3 branch November 1, 2017 21:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants