This repository has been archived by the owner on Sep 28, 2021. It is now read-only.
upgrade to okhttp3 #224
Closed
upgrade to okhttp3 #224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
also upgrade okio okhttp 2.x is obsolete, and according to https://github.com/square/okhttp/blob/master/CHANGELOG.md#version-300-rc1 there should be no risk to upgrade.
|
This is probably a breaking change though. okhttp3 default uses lower case for header key? |
|
@honnix header keys should be treated in a case-insensitive manner though. Are we not doing that? |
|
Not sure of that and hard to presume. |
|
@pettermahlen that feels safe already in Apollo world. But it seems okhttp3 lowers down the case already when building headers, which means things going out of Apollo (and potentially to other system) are different now. If everyone behaves according to RFC, that should be ok though. |
|
#209 :) |
|
this however doesn't pass |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
also upgrade okio
okhttp 2.x is obsolete, and according to https://github.com/square/okhttp/blob/master/CHANGELOG.md#version-300-rc1
there should be no risk to upgrade.
backport of #220